Add HMAC-SHA512 midstate path, vanity PBKDF2 and GPU regression tests#7
Closed
arkadianet wants to merge 1 commit intomainfrom
Closed
Add HMAC-SHA512 midstate path, vanity PBKDF2 and GPU regression tests#7arkadianet wants to merge 1 commit intomainfrom
arkadianet wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
HmacSha512MidstateCtxandhmac_sha512_midstate_init()plus fixed-length finalizershmac_sha512_msg12()andhmac_sha512_msg64()inkernels/hmac_sha512.clto compute HMAC using cached midstates.pbkdf2_sha512_vanity()inkernels/pbkdf2.cland switchedbip39_entropy_to_seed()inkernels/bip39.clto call the vanity path, including a safety clamp onpassword_len.hmac_sha512_midstate_test,hmac_sha512_midstate_msg12_test, andpbkdf2_vanity_test, and corresponding Rust unit teststest_hmac_sha512_midstate_matches_legacy,test_hmac_sha512_midstate_msg12_matches_legacy, andtest_pbkdf2_vanity_matches_bip39insrc/kernel.rsto compare against legacy kernels.Testing
cargo test --releaseas an automated check, but the build failed due toerg-vanity-cryptousing the unstable Rust featurebigint_helper_methodson the current toolchain, preventing the test suite from completing.Codex Task