Skip to content

abl: feat: add extraargs from armbianEnv for mkbootimg#9341

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
CodeChenL:abl
Feb 5, 2026
Merged

abl: feat: add extraargs from armbianEnv for mkbootimg#9341
igorpecovnik merged 1 commit intoarmbian:mainfrom
CodeChenL:abl

Conversation

@CodeChenL
Copy link
Contributor

@CodeChenL CodeChenL commented Feb 2, 2026

Description

Add extraargs from armbianENV.txt to the cmdline option for mkbootimg

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • After applying this modification and reinstalling the kernel:
chen@xiaomi-elish:~$ cat /boot/armbianEnv.txt 
abl_boot_partition_label=boot_b
rootdev=UUID=940c68fe-1909-4918-9f8a-198b1582f0b2
rootfstype=ext4
extraargs=cpufreq.default_governor=schedutil
usbstoragequirks=0x2537:0x1066:u,0x2537:0x1068:u
chen@xiaomi-elish:~$ cat /proc/cmdline 
root=UUID=0552a964-89db-4af3-ade9-5f49d671df7e slot_suffix=_b cpufreq.default_governor=schedutil androidboot.verifiedbootstate=orange androidboot.keymaster=1 androidboot.vbmeta.device=PARTUUID=cd1cfbb7-7a7f-9f61-e1dc-df3128bdbcc9 androidboot.vbmeta.avb_version=1.0 androidboot.vbmeta.device_state=unlocked androidboot.vbmeta.hash_alg=sha256 androidboot.vbmeta.size=7872 androidboot.vbmeta.digest=05846afbe0b8ecc7023969e198f2b8b5822adb9573514e81abf0341964144c7f androidboot.vbmeta.invalidate_on_error=yes androidboot.veritymode=enforcing androidboot.bootdevice=1d84000.ufshc androidboot.fstab_suffix=default androidboot.boot_devices=soc/1d84000.ufshc androidboot.serialno=c1a6c19b androidboot.secureboot=1 androidboot.hwversion=C.9.0 androidboot.cpuid=0x3c53066a androidboot.hwc=CN androidboot.hwlevel=MP androidboot.baseband=apq msm_drm.dsi_display0=qcom,mdss_dsi_k81_42_02_0a_dual_cphy_video: androidboot.oled_wp=858286 androidboot.force_normal_boot=1 androidboot.ramdump=disable block2mtd.block2mtd=/dev/block/sda15,2097152 mtdoops.mtddev=0 mtdoops.record_size=2097152 mtdoops.dump_oops=0 printk.always_kmsg_dump=1 androidboot.dp=0x0 androidboot.cert=M2105K81AC

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated kernel boot parameter configurations for OnePlus Kebab and Xiaomi Elish device models.

Signed-off-by: CodeChenL <2540735020@qq.com>
@CodeChenL CodeChenL requested review from a team and igorpecovnik as code owners February 2, 2026 18:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

The changes consistently append the ${extraargs} variable to existing kernel boot command line arguments across three boot-related configuration files, while preserving all prior arguments.

Changes

Cohort / File(s) Summary
Boot Command Line Enhancement
extensions/image-output-abl.sh, packages/bsp/oneplus-kebab/zz-update-abl-kernel, packages/bsp/xiaomi-elish/zz-update-abl-kernel
Appended ${extraargs} variable to kernel boot command line arguments in mkbootimg and boot image construction, enabling additional kernel parameters to be passed through while preserving existing arguments like slot_suffix and root=UUID.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hop hop, the extraargs now align,
Three boot commands in perfect line,
From shell to kebab, to elish's glow,
Extra parameters steal the show! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding support for extraargs from armbianEnv to mkbootimg command line across multiple boot files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components BSP Board Support Packages labels Feb 2, 2026
@CodeChenL CodeChenL changed the title feat: Add extraargs from armbianENV to the cmdline option for mkbootimg feat: add extraargs from armbianEnv for mkbootimg Feb 2, 2026
@rpardini rpardini changed the title feat: add extraargs from armbianEnv for mkbootimg abl: feat: add extraargs from armbianEnv for mkbootimg Feb 3, 2026
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Feb 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Feb 4, 2026
@igorpecovnik igorpecovnik merged commit e6d22be into armbian:main Feb 5, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release BSP Board Support Packages Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants