Skip to content

Conversation

@Grippy98
Copy link
Contributor

@Grippy98 Grippy98 commented Feb 3, 2026

Fixes Apt catching by using post_armbian_repo_customize_image

Fix PocketBeagle2 DTB name change

Add missing KConfig required for PCIe

Description

PB2 had DTS files moved to DTB in upstream Beagle repo
Used post_armbian_repo_customize_image to fix breaking cache as suggested by Igor
Added missing CONFIG_SOCIONEXT_SYNQUACER_PREITS required for MSI interrupts from PCIe -> GIC ITS to work.

How Has This Been Tested?

  • Tested booting on PB2 and that TI Debpkgs are still present.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features

    • Enabled Synquacer PREITS kernel support across multiple configuration profiles.
  • Chores

    • Updated device boot configuration to reference the device tree binary format for improved compatibility.
  • Refactor

    • Renamed a public script function to align with current naming conventions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Changed PocketBeagle2 BOOT_FDT_FILE from a .dts to a .dtb, enabled CONFIG_SOCIONEXT_SYNQUACER_PREITS in multiple K3 kernel defconfigs, and renamed an exported hook function in the TI Debian-packages extension.

Changes

Cohort / File(s) Summary
Board Configuration
config/boards/pocketbeagle2.conf
Updated BOOT_FDT_FILE from "ti/k3-am6232-pocketbeagle2.dts" to "ti/k3-am6232-pocketbeagle2.dtb".
Kernel Configuration
config/kernel/linux-k3-beagle-edge.config, config/kernel/linux-k3-beagle-vendor-rt.config, config/kernel/linux-k3-beagle-vendor.config, config/kernel/linux-k3-edge.config, config/kernel/linux-k3-vendor-edge.config, config/kernel/linux-k3-vendor-rt.config
Added CONFIG_SOCIONEXT_SYNQUACER_PREITS=y to six K3-related defconfig files.
Extension Hook
extensions/ti-debpkgs.sh
Renamed exported function from custom_apt_repo__install_ti_packages() to post_repo_customize_image__install_ti_packages() (implementation unchanged).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hop through patches, nibble a byte,
.dts to .dtb—now snug and tight,
PREITS wakes up in kernel dreams,
A function renamed, soft as streams,
Carrots, commits, and moonlit beams. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the three main changes: APT caching fix, PocketBeagle2 device tree update, and addition of missing kernel configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components 02 Milestone: First quarter release labels Feb 3, 2026
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@config/boards/pocketbeagle2.conf`:
- Line 19: The BOOT_FDT_FILE value was changed to a .dtb but must use the source
.dts like the other TI K3 boards; update the BOOT_FDT_FILE setting (reference:
BOOT_FDT_FILE in pocketbeagle2 config) to "ti/k3-am6232-pocketbeagle2.dts" so
the build system compiles it to a .dtb automatically, restoring consistency with
the other TI K3 board configs.
🧹 Nitpick comments (1)
extensions/ti-debpkgs.sh (1)

7-8: Function rename looks appropriate for APT caching fix; minor whitespace issue on line 8.

Renaming from custom_apt_repo__ to post_armbian_repo_customize_image__ changes when this hook executes in the build process, which should address the APT caching issues mentioned in the PR objectives.

Line 8 contains only whitespace (trailing tab/spaces) which could be cleaned up.

🧹 Optional: Remove trailing whitespace
 function post_armbian_repo_customize_image__install_ti_packages() {
-	
+
     # Read JSON array into Bash array safely

Fixes Apt catching by using post_armbian_repo_customize_image

Fix PB2 DTB name change

Add missing KConfig required for PCIe
Copy link
Contributor

@jonaswood01 jonaswood01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also test apt update and apt install/apt remove of a TI deb pkg?

LGTM, assuming this is tested

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Feb 4, 2026
@Grippy98 Grippy98 merged commit 8ba25ce into armbian:main Feb 4, 2026
13 checks passed
@Grippy98 Grippy98 deleted the PB2-Fix branch February 4, 2026 22:53
yury-deltsov pushed a commit to yury-deltsov/build that referenced this pull request Feb 8, 2026
* Fix K3 issues - APT Caching, PB2, Missing KConfig

Fixes Apt catching by post_repo_customize_image__install_ti_packages

Fix PB2 DTB name change

Add missing KConfig required for PCIe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

5 participants