-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Fix K3 issues - APT Caching, PB2, Missing KConfig #9349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughChanged PocketBeagle2 BOOT_FDT_FILE from a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@config/boards/pocketbeagle2.conf`:
- Line 19: The BOOT_FDT_FILE value was changed to a .dtb but must use the source
.dts like the other TI K3 boards; update the BOOT_FDT_FILE setting (reference:
BOOT_FDT_FILE in pocketbeagle2 config) to "ti/k3-am6232-pocketbeagle2.dts" so
the build system compiles it to a .dtb automatically, restoring consistency with
the other TI K3 board configs.
🧹 Nitpick comments (1)
extensions/ti-debpkgs.sh (1)
7-8: Function rename looks appropriate for APT caching fix; minor whitespace issue on line 8.Renaming from
custom_apt_repo__topost_armbian_repo_customize_image__changes when this hook executes in the build process, which should address the APT caching issues mentioned in the PR objectives.Line 8 contains only whitespace (trailing tab/spaces) which could be cleaned up.
🧹 Optional: Remove trailing whitespace
function post_armbian_repo_customize_image__install_ti_packages() { - + # Read JSON array into Bash array safely
Fixes Apt catching by using post_armbian_repo_customize_image Fix PB2 DTB name change Add missing KConfig required for PCIe
jonaswood01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also test
apt updateandapt install/apt removeof a TI deb pkg?
LGTM, assuming this is tested
|
✅ This PR has been reviewed and approved — all set for merge! |
* Fix K3 issues - APT Caching, PB2, Missing KConfig Fixes Apt catching by post_repo_customize_image__install_ti_packages Fix PB2 DTB name change Add missing KConfig required for PCIe
Fixes Apt catching by using post_armbian_repo_customize_image
Fix PocketBeagle2 DTB name change
Add missing KConfig required for PCIe
Description
PB2 had DTS files moved to DTB in upstream Beagle repo
Used post_armbian_repo_customize_image to fix breaking cache as suggested by Igor
Added missing CONFIG_SOCIONEXT_SYNQUACER_PREITS required for MSI interrupts from PCIe -> GIC ITS to work.
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Chores
Refactor