This repository was archived by the owner on Jul 11, 2023. It is now read-only.
Update the gallery shortcode#144
Open
McGun wants to merge 1 commit intoarnabwahid:masterfrom
McGun:patch-1
Open
Update the gallery shortcode#144McGun wants to merge 1 commit intoarnabwahid:masterfrom McGun:patch-1
McGun wants to merge 1 commit intoarnabwahid:masterfrom
McGun:patch-1
Conversation
Now the images does not have to be attached to the specific post/page as the shortcodes goes in. Someone may have to look a bit closer to the code. I'm not a php-guru, but it took me a few hours to work this out. Anyway, I hope this contributes to the project.
Contributor
|
Yes, there are a few issues with the gallery atm. @McGun, switching to your branch through out a few errors: The original code shows the gallery. Hopefully a couple of fixes will make it work. |
|
The solution is here |
Author
|
Great that there already is a solution! =) |
|
This code fix is broken. The new line #15 is: $ids = explode(",",$array['ids']); it should be: $ids = explode(",",$attr['ids']); |
|
Guys, I found a little bug in new line #32: $output .= wp_get_attachment_link( $attachment->ID , 'thubnail', true ); should be $output .= wp_get_attachment_link( $attachment->ID , 'thumbnail', true ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the images does not have to be attached to the specific post/page as the shortcodes goes in.
Someone may have to look a bit closer to the code. I'm not a php-guru, but it took me a few hours to work this out. Anyway, I hope this contributes to the project.