feat: remove multiple plugins at once#2163
Open
joaovictorsl wants to merge 1 commit intoasdf-vm:masterfrom
Open
feat: remove multiple plugins at once#2163joaovictorsl wants to merge 1 commit intoasdf-vm:masterfrom
joaovictorsl wants to merge 1 commit intoasdf-vm:masterfrom
Conversation
Author
|
Is this ok or is there a reason why removing multiple plugins at once would go wrong? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
I wanted to remove multiple plugins on a single command
How?
Make pluginRemoveCommand take a slice instead of only the first plugin name, then we loop through them and remove one by one. If any error happens when removing a plugin we return before finishing the loop.