Skip to content

Fix errors reported in Git Actions for code-quality and test workflows #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qychen2001 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix errors reported in Git Actions for code-quality and test workflows #643

qychen2001 wants to merge 2 commits into from

Conversation

@qychen2001
Copy link

@qychen2001 qychen2001 commented Jun 25, 2024

What does this PR do?

This PR fixes errors reported by Git Actions when executing code quality and test workflows for new repositories using this template.

The main reason is due to:

  1. The code quality workflow uses Python 3.12, which introduces additional dependency issues
  2. The default installation of numpy using pip installs the latest version of 2.0.0, which causes the test workflow to report errors on Windows systems.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

image

@qychen2001
ci: 💚 Pin Python version to 3.10.14 in GitHub Actions workflows
a6799c2 
Pin the Python version used in GitHub Actions for both code-quality-main.yaml and code-quality-pr.yaml workflows to prevent compatibility errors with default Python 3.12.
@qychen2001
ci: 💚 Install numpy<2.0.0 to ensure compatibility with other packages
9dae333 
Installing numpy version less than 2.0.0 in the GitHub Actions test workflow to prevent potential compatibility issues with other dependencies specified in requirements.txt.
@GeonHyeock GeonHyeock mentioned this pull request Jul 14, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@qychen2001