adding bracket matching #387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParticularlyPythonicBS
force-pushed
the
feat/rainbow_brackets
branch
3 times, most recently
from
90fcc62 to
2aa2c99
Compare
ParticularlyPythonicBS
force-pushed
the
feat/rainbow_brackets
branch
from
2aa2c99 to
26957d9
Compare
|
that's pretty cool :o |
Owner
|
agreed! as talked about on stream this is really awesome and I'm super impressed you got this working so well! the unfortunate side of it (also as discussed) is this probably isn't something I'd have on by default, which likely means I wouldn't use it, and likely means it would just be a maintenance burden but we also discussed the less impactful brace matching approach -- so I'm excited for that! |
ParticularlyPythonicBS
force-pushed
the
feat/rainbow_brackets
branch
2 times, most recently
from
8bf0dbf to
c157627
Compare
ParticularlyPythonicBS
force-pushed
the
feat/rainbow_brackets
branch
from
c157627 to
8d4d1c8
Compare
ParticularlyPythonicBS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented bracket matching. If theme has bold fonts, bolds the brackets when in scope, always makes any unmatched bracket bold and red