Skip to content

fix testonly with js_binary so it's not a test #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aghassi wants to merge 3 commits into
base: 2.x
Choose a base branch
from
+4 −2
Open

fix testonly with js_binary so it's not a test #1486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ddaaa
fix `testonly` with js_binary
Aghassi Feb 21, 2024
4c1cb9b
refactor to use _is_test attribute instead
Aghassi Feb 21, 2024
7c5a071
Update js/private/js_binary.bzl
Aghassi Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/private/js_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,11 +559,10 @@ def _js_binary_impl(ctx):

providers = []

if ctx.attr.testonly and ctx.configuration.coverage_enabled:
if ctx.attr.testonly and ctx.configuration.coverage_enabled and hasattr(ctx.attr, "_is_test"):
# We have to instruct rule implementers to have this attribute present.
if not hasattr(ctx.attr, "_lcov_merger"):
fail("_lcov_merger attribute is missing and coverage was requested")

# We have to propagate _lcov_merger runfiles since bazel does not treat _lcov_merger as a proper tool.
# See: https://github.com/bazelbuild/bazel/issues/4033
runfiles = runfiles.merge(ctx.attr._lcov_merger[DefaultInfo].default_runfiles)
Expand Down Expand Up @@ -641,6 +640,9 @@ the contract between Bazel and a test runner.""",
default = Label("//js/private/coverage:merger"),
cfg = "exec",
),
"_is_test": attr.bool(
default = True
)
}),
test = True,
toolchains = js_binary_lib.toolchains,
Expand Down