Skip to content

Conversation

@mkanat
Copy link
Contributor

@mkanat mkanat commented Feb 9, 2026

Summary

  • Adds --quiet flag to all ruff check invocations (both lint and fix mode)
  • Suppresses the "All checks passed!" stderr message that floods CI output for every target
  • --quiet still prints diagnostics, just nothing else — so actual lint errors are unaffected

Fixes #753

Test plan

  • //test:ruff_should_ignore_generated — PASSED
  • //test:ruff_should_ignore_generated_filegroup — PASSED
  • //test:ruff_should_ignore_excluded — PASSED
  • //test:ruff_machine_output_test — PASSED (SARIF output unaffected)
  • //test:ruff_pyi_machine_output_test — PASSED (SARIF output unaffected)
  • bazel build --config=lint --output_groups=rules_lint_human //src:all — success
  • bazel build --config=lint --output_groups=rules_lint_patch --@aspect_rules_lint//lint:fix //src:all — success

🤖 Generated with Claude Code

Add --quiet flag to ruff check invocations so that successful lint runs
don't flood CI output with "All checks passed!" for every target.

Fixes aspect-build#753

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link

CLAassistant commented Feb 9, 2026

CLA assistant check
All committers have signed the CLA.

@aspect-workflows
Copy link

aspect-workflows bot commented Feb 9, 2026

Bazel 7 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Bazel 8 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.


Bazel 9 (Test)

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 21b8fac into aspect-build:main Feb 9, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ruff lint aspect is very noisy on success

3 participants