feat: support bazel path-mapping #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
2574-cross-mode
branch
from
7d0c0a4 to
fd03a70
Compare
dzbarsky
approved these changes
Dec 11, 2025
Collaborator
dzbarsky
left a comment
dzbarsky
left a comment
There was a problem hiding this comment.
I guess it doesn't hurt but it seems like more work is needed to have any useful effect
Member
Author
|
Why is that? The TODOs only effects the plugin path which I rarely see used. Plugins being invoked (especially if they are node plugins) on a per-.ts file has never worked out well afaict... |
Collaborator
Oh sorry I misread the PR, if it's only plugins then we're good. Ship away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref aspect-build/rules_js#2574
Changes are visible to end-users: yes
Support transpiler usage across compilation modes.
Test plan