Use the current major version of async-channel#1092
Open
musicinmybrain wants to merge 1 commit intoasync-rs:mainfrom
Open
Use the current major version of async-channel#1092musicinmybrain wants to merge 1 commit intoasync-rs:mainfrom
musicinmybrain wants to merge 1 commit intoasync-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn’t attempt to audit the code and compare it to the breaking changes noted in https://github.com/smol-rs/async-channel/blob/v2.3.1/CHANGELOG.md#version-200. I did run
cargo test --no-fail-fastand didn’t observe any regressions (to_socket_addr_str_badpanics for me both before and after this PR).