feat(net): implement more methods for TcpStream#507
Open
dignifiedquire wants to merge 1 commit intoasync-rs:mainfrom
Open
feat(net): implement more methods for TcpStream#507dignifiedquire wants to merge 1 commit intoasync-rs:mainfrom
dignifiedquire wants to merge 1 commit intoasync-rs:mainfrom
Conversation
- connect_timeout - take_error Ref async-rs#499
yoshuawuyts
requested changes
Nov 20, 2019
Contributor
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
Both these APIs look 💯 Allwe need to do to land them now is to mark them "unstable", and then we're good to go. Thanks heaps @dignifiedquire!
ghost
suggested changes
Jan 13, 2020
| /// Unlike `connect`, `connect_timeout` takes a single `SocketAddr` since | ||
| /// timeout must be applied to individual addresses. | ||
| /// | ||
| /// It is an error to pass a zero `Duration` to this function. |
There was a problem hiding this comment.
This doc comment is missing an example. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect_timeouttake_errorRef #499