fix: clean up deprecated and unused dependencies#4997
fix: clean up deprecated and unused dependencies#4997sammy200-ui wants to merge 3 commits intoasyncapi:masterfrom
Conversation
sammy200-ui
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughUpdated Heroicons imports and several icon component names to the v2 import path; migrated Floating UI usage from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR cleans up deprecated and unused dependencies to maintain the codebase with current recommended versions. The changes are focused on dependency upgrades and removals that have no functional impact, only improving maintainability.
Changes:
- Removed
@tailwindcss/line-clampplugin (functionality now built into Tailwind CSS v3.3+) - Removed deprecated
@storybook/addonspackage - Migrated from
@floating-ui/react-dom-interactionsto@floating-ui/reactwith updated API usage - Upgraded
@heroicons/reactfrom v1.0.6 to v2.2.0 with updated icon names and import paths
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed deprecated dependencies (@storybook/addons, @tailwindcss/line-clamp) and upgraded packages (@heroicons/react, @floating-ui/react) |
| package-lock.json | Updated lockfile to reflect dependency changes, removed transitive dependencies of deprecated packages |
| pages/tools/cli.tsx | Updated heroicons imports from v1 outline to v2 24/outline, renamed icons to new v2 names |
| pages/[lang]/tools/cli.tsx | Updated heroicons imports from v1 outline to v2 24/outline, renamed icons to new v2 names |
| pages/community/events/index.tsx | Updated heroicons imports from v1 outline to v2 24/outline |
| components/navigation/toolingItems.tsx | Updated heroicons imports, renamed TerminalIcon to CommandLineIcon |
| components/navigation/EventPostItem.tsx | Updated heroicons imports from v1 outline to v2 24/outline |
| components/layout/CommunityLayout.tsx | Updated heroicons imports from v1 outline to v2 24/outline |
| components/Meeting.tsx | Updated heroicons imports from v1 outline to v2 24/outline |
| components/dashboard/table/Filters.tsx | Migrated from @floating-ui/react-dom-interactions to @floating-ui/react, updated API from reference/floating to refs.setReference/refs.setFloating |
| components/dashboard/GoodFirstIssuesTip.tsx | Migrated from @floating-ui/react-dom-interactions to @floating-ui/react, updated API from reference/floating to refs.setReference/refs.setFloating |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4997 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 52-53: The dependency entries for "@floating-ui/react" and
"@heroicons/react" are caret-pinned to older minor versions and won't
auto-update to the newer minor releases; update the package.json dependency
versions from "^0.26.0" to "^0.27.16" for "@floating-ui/react" and from "^2.1.0"
to "^2.2.0" for "@heroicons/react" (or explicitly decide to keep the current
specs) and run your package manager install to lock the chosen versions,
ensuring the changes are reflected in lockfile updates.
| "@floating-ui/react": "^0.26.0", | ||
| "@heroicons/react": "^2.1.0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check latest versions of the updated packages
echo "Checking `@floating-ui/react` latest version:"
curl -s https://registry.npmjs.org/@floating-ui/react/latest | jq '.version'
echo "Checking `@heroicons/react` latest version:"
curl -s https://registry.npmjs.org/@heroicons/react/latest | jq '.version'Repository: asyncapi/website
Length of output: 163
Dependency updates look correct.
The migration from deprecated packages aligns with the PR objectives:
@floating-ui/reactreplaces the deprecated@floating-ui/react-dom-interactions@heroicons/reactv2.1.0 is a major version upgrade from v1.x
Note: Newer minor versions are available (@floating-ui/react@0.27.16 and @heroicons/react@2.2.0). The current caret-pinned versions (^0.26.0 and ^2.1.0) are acceptable and will receive patch updates automatically, but will not upgrade to these newer minor versions without explicit updates to the version specifiers.
🤖 Prompt for AI Agents
In `@package.json` around lines 52 - 53, The dependency entries for
"@floating-ui/react" and "@heroicons/react" are caret-pinned to older minor
versions and won't auto-update to the newer minor releases; update the
package.json dependency versions from "^0.26.0" to "^0.27.16" for
"@floating-ui/react" and from "^2.1.0" to "^2.2.0" for "@heroicons/react" (or
explicitly decide to keep the current specs) and run your package manager
install to lock the chosen versions, ensuring the changes are reflected in
lockfile updates.
There was a problem hiding this comment.
its intentional to use stable versions
There was a problem hiding this comment.
@sammy200-ui, understood! Using stable, well-tested versions is a reasonable approach, especially for a production website. The caret-pinned versions you've chosen will still receive patch updates for bug fixes while avoiding potential breaking changes or regressions from newer minor releases.
✏️ Learnings added
Learnt from: sammy200-ui
Repo: asyncapi/website PR: 4997
File: package.json:52-53
Timestamp: 2026-01-22T16:02:24.768Z
Learning: For the asyncapi/website repository, sammy200-ui prefers using stable, well-tested versions of dependencies rather than the absolute latest minor versions, prioritizing stability over newest features.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: sammy200-ui
Repo: asyncapi/website PR: 4804
File: components/navigation/Filter.tsx:32-41
Timestamp: 2025-12-29T14:21:43.887Z
Learning: For the asyncapi/website repository, maintainer guidance is to use eslint-disable comments with explanatory text for cases where useEffect/useMemo dependencies are intentionally omitted by design.
7b38ea9 to
9d904c7
Compare
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4997--asyncapi-website.netlify.app/ |
|
@princerajpoot20 pr is open for review!! |
sammy200-ui
force-pushed
the
fix/cleanup-deprecated-dependencies
branch
from
9d904c7 to
71e4fd8
Compare
|
@princerajpoot20 got conflict because of the lock file regeneration , open for review now !! |
sammy200-ui
force-pushed
the
fix/cleanup-deprecated-dependencies
branch
2 times, most recently
from
412eb8e to
e39ef9f
Compare
|
hello @princerajpoot20 following up on this pr , anything from my side that needs to be updated or can we proceed with this |
|
@sammy200-ui Please proceed with the sanity checks using the temporary deployment link for all the components where you have made code changes. This will ensure that the changes are GTG. |
|
Also, the CI pipeline is failing. have a look at it |
|
@princerajpoot20 sure , will attach the evidence for it here . hmm...thats weird CI passed yesterday , let me take a look at it as well |
- Remove @tailwindcss/line-clamp (built into Tailwind CSS v3.3+) - Remove @storybook/addons (deprecated, unused) - Replace @floating-ui/react-dom-interactions with @floating-ui/react - Upgrade @heroicons/react from v1.x to v2.x Closes asyncapi#4983
sammy200-ui
force-pushed
the
fix/cleanup-deprecated-dependencies
branch
from
95b764b to
b42c8b0
Compare
|
|
@princerajpoot20 here are the evidence - |
4 participants
here are the references -
1 - https://www.npmjs.com/package/@floating-ui/react-dom-interactions
2 - https://tailwindcss.com/blog/tailwindcss-v3-3#line-clamp-out-of-the-box
3 - https://storybook.js.org/docs/8/migration-guide#package-structure-changes
4 - https://github.com/tailwindlabs/heroicons#react
all of them are in order of there mentions
Closes #4983
Summary by CodeRabbit
Chores
Style