Conversation
sauraviiitk
requested review from
Mayaleeeee,
akshatnema,
anshgoyalevil,
asyncapi-bot-eve,
derberg,
princerajpoot20 and
sambhavgupta0705
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We require all PRs to follow Conventional Commits specification. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
📝 WalkthroughWalkthroughThe Modal component's title element is updated to support multi-line text with word breaking and whitespace normalization, replacing truncated single-line display. The content area's maximum height is reduced on large screens from 70vh to 50vh, and minor className formatting adjustments are applied throughout. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5018--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@components/Modal.tsx`:
- Around line 57-58: In the Modal component JSX, remove accidental double spaces
inside className strings (e.g., in the outer container div and the header div
and the element with "w-full overflow-auto") so classes are single-space
separated; update the className values in the Modal component (the JSX divs
around the modal content and the header/scroll container) to collapse double
spaces into single spaces while preserving all class names and ordering.
- Around line 59-60: Prettier is failing because the h1 JSX element is split
across lines; collapse the opening tag, content, and closing tag into a single
line so the <h1 className='mr-4 text-lg font-bold break-words
whitespace-normal'>{title}</h1> JSX expression is one line in
components/Modal.tsx (locate the h1 element that renders the title) to satisfy
formatting rules.
| <div className='relative m-auto overflow-hidden rounded-lg bg-white px-4 pb-4 pt-5 text-left shadow-xl transition-all sm:w-full sm:max-w-4xl sm:p-6'> | ||
| <div className='mb-6 flex justify-between'> |
There was a problem hiding this comment.
Remove unintentional double spaces in className strings.
Lines 57, 58, and 74 contain double spaces in the className strings (e.g., bg-white px-4, mb-6 flex, w-full overflow-auto). These appear to be formatting artifacts rather than intentional.
Proposed fix
- <div className='relative m-auto overflow-hidden rounded-lg bg-white px-4 pb-4 pt-5 text-left shadow-xl transition-all sm:w-full sm:max-w-4xl sm:p-6'>
- <div className='mb-6 flex justify-between'>
+ <div className='relative m-auto overflow-hidden rounded-lg bg-white px-4 pb-4 pt-5 text-left shadow-xl transition-all sm:w-full sm:max-w-4xl sm:p-6'>
+ <div className='mb-6 flex justify-between'>- <div className='max-h-[65vh] w-full overflow-auto lg:max-h-[50vh]'>{children}</div>
+ <div className='max-h-[65vh] w-full overflow-auto lg:max-h-[50vh]'>{children}</div>Also applies to: 74-74
🤖 Prompt for AI Agents
In `@components/Modal.tsx` around lines 57 - 58, In the Modal component JSX,
remove accidental double spaces inside className strings (e.g., in the outer
container div and the header div and the element with "w-full overflow-auto")
so classes are single-space separated; update the className values in the Modal
component (the JSX divs around the modal content and the header/scroll
container) to collapse double spaces into single spaces while preserving all
class names and ordering.
| <h1 className='mr-4 text-lg font-bold break-words whitespace-normal'> | ||
| {title}</h1> |
There was a problem hiding this comment.
Fix Prettier formatting error to unblock CI.
The pipeline is failing due to the line break between the h1 opening tag and closing tag. Prettier expects this to be on a single line.
Proposed fix
- <h1 className='mr-4 text-lg font-bold break-words whitespace-normal'>
- {title}</h1>
+ <h1 className='mr-4 text-lg font-bold break-words whitespace-normal'>{title}</h1>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <h1 className='mr-4 text-lg font-bold break-words whitespace-normal'> | |
| {title}</h1> | |
| <h1 className='mr-4 text-lg font-bold break-words whitespace-normal'>{title}</h1> |
🧰 Tools
🪛 GitHub Actions: PR testing - if Node project
[error] 59-59: Prettier formatting error. Replace the line break in the h1 tag to satisfy prettier/prettier.
🤖 Prompt for AI Agents
In `@components/Modal.tsx` around lines 59 - 60, Prettier is failing because the
h1 JSX element is split across lines; collapse the opening tag, content, and
closing tag into a single line so the <h1 className='mr-4 text-lg font-bold
break-words whitespace-normal'>{title}</h1> JSX expression is one line in
components/Modal.tsx (locate the h1 element that renders the title) to satisfy
formatting rules.
2 participants
Description
Related issue(s)
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.