Skip to content

feat: add async arrow button rotation fix for issue #4984#5076

Open
dagger-5328 wants to merge 1 commit intoasyncapi:masterfrom
dagger-5328:feature-navbar-button-fix-#4984
Open

feat: add async arrow button rotation fix for issue #4984#5076
dagger-5328 wants to merge 1 commit intoasyncapi:masterfrom
dagger-5328:feature-navbar-button-fix-#4984

Conversation

@dagger-5328
Copy link

@dagger-5328 dagger-5328 commented Feb 3, 2026

Related Issues : #4984

Summary by CodeRabbit

  • New Features
    • Added smooth rotation animation to navigation dropdown items on hover and focus.
    • Introduced internationalization support for multi-language functionality.

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f2c8d6b
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6981982a9eb72e0008d21b28
😎 Deploy Preview https://deploy-preview-5076--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The pull request adds a rotation animation to the NavItemDropdown icon on hover and focus states via Tailwind utilities, and introduces the react-i18next dependency for internationalization support.

Changes

Cohort / File(s) Summary
SVG Animation Enhancement
components/icons/NavItemDropdown.tsx
Added transform and rotation utilities (group-hover:rotate-180 and group-focus:rotate-180) to enable dropdown icon rotation on interaction.
Dependency Addition
package.json
Added react-i18next (^16.5.4) as a runtime dependency for internationalization support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A dropdown spins with graceful ease,
As hovers dance and focus sees,
The i18n enters with a bound,
Languages now can come around! 🌍✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'async arrow button rotation fix' which aligns with changes to NavItemDropdown.tsx adding rotation utilities, but the addition of react-i18next dependency is unrelated to this title. Clarify whether the react-i18next dependency addition is part of the rotation fix or if the PR scope should be narrowed to only the NavItemDropdown rotation changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (caebc9d) to head (f2c8d6b).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5076   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          796       796           
  Branches       146       146           
=========================================
  Hits           796       796           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 32
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-5076--asyncapi-website.netlify.app/

@dagger-5328 dagger-5328 changed the title Fix: resolved async arrow button rotation issue feat: add async arrow button rotation fix Feb 3, 2026
@SHUBHANSHU602
Copy link

Please mention issue number in the PR .

@dagger-5328 dagger-5328 changed the title feat: add async arrow button rotation fix feat: add async arrow button rotation fix for issue #4984 Feb 3, 2026
@yashdarekar17
Copy link

yashdarekar17 commented Feb 5, 2026

@dagger-5328 please read the issue #4984 carefully i am willing to work on this issue and maintainer gave me approval to create a pr so please ask that if this issue is open or not before making a pr and i have submitted the pr which is under review and its not for my issue its for other issues also

@dagger-5328
Copy link
Author

@yashdarekar17 Thanks for the clarification! Apologies for the confusion — this is my first PR, so I’m still learning the contribution process. I’ll make sure to follow this going forward. Thanks for your guidance!

@SHUBHANSHU602
Copy link

@yashdarekar17 Thanks for the clarification! Apologies for the confusion — this is my first PR, so I’m still learning the contribution process. I’ll make sure to follow this going forward. Thanks for your guidance!

No problem @dagger-5328 this keeps happening we all go through same phase once but next time follow the proper giudelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Be Triaged

Development

Successfully merging this pull request may close these issues.

4 participants