fix(roam-import): single digit roam dates are padded with a left zero.#1268
Open
julionav wants to merge 2 commits intoathensresearch:mainfrom
Open
fix(roam-import): single digit roam dates are padded with a left zero.#1268julionav wants to merge 2 commits intoathensresearch:mainfrom
julionav wants to merge 2 commits intoathensresearch:mainfrom
Conversation
Contributor
|
Please fix style (run |
Collaborator
|
Yeah tests would be nice here (even though there aren't any for this yet). |
between roam-dates and athens-dates
Contributor
Author
|
Added tests here, but when running script/style it says that there are 3 files incorrectly formatted, but it doesn't format them. Getting this at the end: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves: #1263
The issue was caused by
athens.patterns/replace-roam-dateonly replacing the "cardinal" part of the date (th, st, etc); but not adding the 0 padding at the start of the number.