AXON-1526-additional-changes-to-include-jira.com #1484
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teg-atlassian
requested review from
Blastoplex,
amarg-at,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian and
sspanchenko
as code owners
| if (dragDropData.find((x) => x.includes('atlascode.views.jira.assignedWorkItemsTreeView'))) { | ||
| const uri = URL.parse(dragDropData[0] || dragDropData[1]); | ||
| if (uri?.hostname.endsWith('.atlassian.net')) { | ||
| if (uri?.hostname.endsWith('.atlassian.net') || uri?.hostname.endsWith('.jira.com')) { |
Collaborator
There was a problem hiding this comment.
Why doesn't this make use of the function?
teg-atlassian
changed the title
teg-atlassian
changed the title
teg-atlassian
requested review from
BHulovatyi and
sky-ocean-spirits
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
This PR address the issue reported here by user. Already a change was made but additional changes were needed and thus this pr.
How Has This Been Tested?
checked how many matches are there for the following regex and there is none. The regex checks if we have statements that only verifies about atlassian.net. We want any such statements to also check for jira.com as an alternative domain for cloud .
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations:
Rovo Dev tried to review the code but something went wrong.
Check possible errors