JPERF-445: Use ssh-ubuntu instead of inlined Docker code#7
JPERF-445: Use ssh-ubuntu instead of inlined Docker code#7dagguh wants to merge 1 commit intoatlassian:masterfrom
ssh-ubuntu instead of inlined Docker code#7Conversation
| dataset.database.start(jiraUri, it) | ||
| } | ||
| startJiraNode(jira.ssh, db.peerIp) | ||
| startJiraNode(jira.ssh.becomeUsable(), db.container.getContainerIpAddress()) |
There was a problem hiding this comment.
https://circleci.com/gh/dagguh/virtual-users/60 :
Error while executing sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic
Hmm, the CopyPastedDocker fails to install on Ubuntu bionic. Before this PR we're using xenial
Raised: https://ecosystem.atlassian.net/browse/JPERF-449
There was a problem hiding this comment.
Here's the problem.
ssh-ubuntu is based on rastasheep, which only supports LTS Ubuntu versions, e.g. 16, 18.
infrastructure hardcodes Docker for Ubuntu 17, which is not LTS and therefore not available as rastasheep.
So we gotta unhardcode it from infra AKA https://ecosystem.atlassian.net/browse/JPERF-449 mentioned earlier.
|
|
||
| val dbContainer = SshUbuntuContainer(exposePort(3306)) | ||
| val jiraContainer = SshUbuntuContainer(exposePort(8080)) | ||
| return dbContainer.start().use { db -> |
There was a problem hiding this comment.
Just an idea. We could avoid the nested containers by introducing a container that would allow registering all the docker containers:
val env = Environment()
env.register(dbContainer)
env.register(jiraContainer)
// env takes care to start and close containers in the right order
env.use{
}
It would be an overkill for two containers but it would improve readability for 3+ containers.
src/test/kotlin/com/atlassian/performance/tools/virtualusers/api/EntryPointIT.kt
Show resolved
Hide resolved
dagguh
force-pushed
the
issue/JPERF-445-switch-back-to-empowered-ssh-ubuntu
branch
from
2e2a260 to
8ca81ea
Compare
|
Resolved conflicts |
4 participants
No description provided.