This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Added inline mode (cycles through suggestions without showing suggestion list)#959
Open
eweitnauer wants to merge 3 commits intoatom:masterfrom
Open
Added inline mode (cycles through suggestions without showing suggestion list)#959eweitnauer wants to merge 3 commits intoatom:masterfrom
eweitnauer wants to merge 3 commits intoatom:masterfrom
Conversation
…he suggestion list
…<tab> can be used as the activation key without losing the ability to indent using <tab>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
I find the suggestion list in autocomplete+ distracting and wanted a mode that cycles through the suggestions without showing the list. I added a new setting called "Inline Mode" to the code that a user can activate to do just that: cycle through all suggestions by repeatedly pressing the autocomplete activation key.
Alternate Designs
This actually is an alternative design to the existing suggestion menu. It provides basically the same functionality as the existing plugin Atom Inline Autocomplete, but works within the autocomplete+ framework.
Benefits
Possible Drawbacks
Since it is an optional mode, I don't see any drawbacks.
Applicable Issues
–
I made this pull request to get feedback on the code. I expect there are more elegant ways to implement it, and I am not sure if it is compatible with all use-cases that autocomplete+ supports. After a code review, I plan to make improvements as requested and add test cases to the specs.