Open
Conversation
Reviewer's GuideStandardized and enriched citation entries in docstrings by appending direct arXiv URLs and unifying the reference style across all methods and class definitions without touching functional code. Class diagram for updated docstring references in ConditionalFlowMatcher and subclassesclassDiagram
class ConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_sigma_t(t)
+sample_xt(x0, x1, t, epsilon)
+compute_conditional_flow(x0, x1, t, xt)
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+compute_lambda(t)
"References updated with arXiv URLs"
}
class ExactOptimalTransportConditionalFlowMatcher {
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+guided_sample_location_and_conditional_flow(x0, x1, y0, y1, t, return_noise)
"References updated with arXiv URLs"
}
class TargetConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_sigma_t(t)
+compute_conditional_flow(x0, x1, t, xt)
"References updated with arXiv URLs"
}
class SchrodingerBridgeConditionalFlowMatcher {
+compute_sigma_t(t)
+compute_conditional_flow(x0, x1, t, xt)
+sample_location_and_conditional_flow(x0, x1, t, return_noise)
+guided_sample_location_and_conditional_flow(x0, x1, y0, y1, t, return_noise)
"References updated with arXiv URLs"
}
class VariancePreservingConditionalFlowMatcher {
+compute_mu_t(x0, x1, t)
+compute_conditional_flow(x0, x1, t, xt)
"References updated with arXiv URLs"
}
ExactOptimalTransportConditionalFlowMatcher --|> ConditionalFlowMatcher
TargetConditionalFlowMatcher --|> ConditionalFlowMatcher
SchrodingerBridgeConditionalFlowMatcher --|> ConditionalFlowMatcher
VariancePreservingConditionalFlowMatcher --|> ConditionalFlowMatcher
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing repeated reference strings (e.g. URLs and author names) in a single constants module or shared variable to avoid duplication and simplify future updates.
- Double-check that citation numbering and formatting remain consistent across all classes and methods after adding the URLs to ensure readers aren’t confused by mismatched labels.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing repeated reference strings (e.g. URLs and author names) in a single constants module or shared variable to avoid duplication and simplify future updates.
- Double-check that citation numbering and formatting remain consistent across all classes and methods after adding the URLs to ensure readers aren’t confused by mismatched labels.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I tried to bring the references in a more homogenous shape and also added them in the class docstrings. This can make it easier for readers to look-up the underlying science to the implementation.
No breaking changes.
Before submitting
pytestcommand?pre-commit run -acommand?All edits were made on github.com
Did you have fun?
yes!
Summary by Sourcery
Enhancements: