Cover WORKSPACE clients with non-standard gtest#634
Merged
Conversation
The motivation is that Aurora's internal code was one such client once, and we might have been broken by the upcoming Au 0.6.0 because of this change. Now our WORKSPACE client project imports googletest by the non-standard name `"com_google_googletest"`. We add a CI test for a target in that project that depends on `//au:testing`, which would cause a conflict without the `repo_mapping` parameter. We also document for end users how to fix this issue.
hoffbrinkle
approved these changes
Jan 16, 2026
timhirsh
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is that Aurora's internal code was one such client once,
and we might have been broken by the upcoming Au 0.6.0 because of this
change.
Now our WORKSPACE client project imports googletest by the non-standard
name
"com_google_googletest". We add a CI test for a target in thatproject that depends on
//au:testing, which would cause a conflictwithout the
repo_mappingparameter.We also document for end users how to fix this issue.