Skip to content

Comments

Fix bzlmod CI failure by loading cc_binary#638

Merged
chiphogg merged 1 commit intomainfrom
chiphogg/fix-bzlmod-ci
Jan 21, 2026
Merged

Fix bzlmod CI failure by loading cc_binary#638
chiphogg merged 1 commit intomainfrom
chiphogg/fix-bzlmod-ci

Conversation

@chiphogg
Copy link
Member

Very surprising that this didn't fail before, as apparently this load
statement was always needed for bzlmod. It started failing in #637 ---
and, interestingly, only on a second commit. Still, the fix is
straightforward.

Very surprising that this didn't fail before, as apparently this load
statement was always needed for bzlmod.  It started failing in #637 ---
and, interestingly, only on a _second_ commit.  Still, the fix is
straightforward.
@chiphogg chiphogg marked this pull request as ready for review January 21, 2026 13:36
@geoffviola
Copy link
Contributor

Very surprising that this didn't fail before

Should we make a change to the github actions workflow to catch this class of errors?

@chiphogg
Copy link
Member Author

Very surprising that this didn't fail before

Should we make a change to the github actions workflow to catch this class of errors?

That's the weird thing. It did catch this error! But for whatever reason, it didn't seem to catch it until several commits after the original error had landed.

We saw something similar with several of the bazel changes in the migration to bzlmod. I think rules_go was the wrong version or something. It never triggered while @hoffbrinkle was landing PRs, and only triggered later when I tried to run the code. These failures have only seemed to happen with bzlmod-related code. It's a little unsettling, but at least we do still seem to get the coverage eventually. 😅

@chiphogg chiphogg merged commit 5fc7a18 into main Jan 21, 2026
27 checks passed
@chiphogg chiphogg deleted the chiphogg/fix-bzlmod-ci branch January 21, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants