Open
Conversation
added 5 commits
December 1, 2019 08:57
# Conflicts: # core/src/main/java/org/jsmart/zerocode/core/runner/ZeroCodeUnitRunner.java
# Conflicts: # core/pom.xml # http-testing/pom.xml # junit5-testing/pom.xml # kafka-testing/pom.xml # pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #365
PR Branch
#ADD LINK TO THE PR BRANCH
https://github.com/ivlahek/zerocode/tree/feature/ISSUE-365
Motivation and Context
Checklist:
Unit tests added?
Integration tests added?
YES
Test names are meaningful?
YES
Feature manually tested?
YES
Branch build passed?
NO, 2 failing as master branc
No 'package.*' in the imports
Relevant Wiki page updated with clear instruction for the end user
Http test added to
http-testingmodule(if applicable) ?Kafka test added to
kafka-testingmodule(if applicable) ?