Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tstirrat15
force-pushed
the
use-tailwind-for-more-things
branch
from
3958b64 to
dbe0467
Compare
tstirrat15
commented
Feb 6, 2026
| foundVia: { | ||
| marginTop: theme.spacing(1), | ||
| }, | ||
| foundViaList: { |
Contributor
Author
There was a problem hiding this comment.
This was the only one that I had to recreate in tailwind; I verified by manual inspection that the styling I've come up with is equivalent.
| [DeveloperError_Source.UNKNOWN_SOURCE]: undefined, | ||
| }; | ||
|
|
||
| const useErrorDisplayStyles = makeStyles((theme: Theme) => |
Contributor
Author
There was a problem hiding this comment.
Most of these styles were already unused as of the beginning of writing this PR
Comment on lines
33
to
34
| // NOTE: the \2192 here is the → character; tailwind needs it as an escape sequence. | ||
| <li className="after:content-['\2192'] after:ml-2 last:after:content-none" key={item}>{item}</li> |
Contributor
Author
There was a problem hiding this comment.
This was a little funky but it works
| <div className={classes.validationErrorContext}> | ||
| <div className="m-2"> | ||
| In | ||
| <Link className={classes.link} to={DataStorePaths.Schema()}> |
Contributor
Author
There was a problem hiding this comment.
I don't think this styling was doing anything.
| import { useEffect, useMemo, useRef, useState } from "react"; | ||
| import { flushSync } from "react-dom"; | ||
|
|
||
| import { useMediaQuery } from "@/hooks/use-media-query"; |
Contributor
Author
There was a problem hiding this comment.
The new hook is interchangeable.
alecmerdler
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of ripping out material. This gets rid of some of the material styling.
Changes
useMediaQueryhookTesting
Review.