Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
miparnisari
commented
Jun 2, 2025
package.json
Outdated
| "@tanstack/react-router": "^1.119.0", | ||
| "@tanstack/react-router-devtools": "^1.119.1", | ||
| "@vercel/node": "^5.2.0", | ||
| "ajv": "^8.17.1", |
Contributor
Author
There was a problem hiding this comment.
FYI
josephschorr
reviewed
Jun 2, 2025
| . generate-config-env.sh | ||
|
|
||
| validate_env "$env_file" | ||
| generate_env "$env_file" |
Member
There was a problem hiding this comment.
Why don't we need this anymore?
Contributor
Author
There was a problem hiding this comment.
Those two functions aren't defined
tstirrat15
approved these changes
Jun 3, 2025
Contributor
tstirrat15
left a comment
There was a problem hiding this comment.
This looks good to me. I spent a second trying to figure out where the connect references went and then realized that it's because we aren't calling the developer service anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed via a late review of f99d639 that there are some dependencies not used anymore.
With the help of
npx knip(https://knip.dev/) I found those, and manually verified that they are no longer needed beforeyarn removethem.BTW This is the output of
knip:Testing
and then verify that everything looks good.