Skip to content

cleanup unused dependencies#73

Merged
miparnisari merged 1 commit intomainfrom
cleanup-yarn
Jun 3, 2025
Merged

cleanup unused dependencies#73
miparnisari merged 1 commit intomainfrom
cleanup-yarn

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Jun 2, 2025

Description

Noticed via a late review of f99d639 that there are some dependencies not used anymore.

With the help of npx knip (https://knip.dev/) I found those, and manually verified that they are no longer needed before yarn remove them.

BTW This is the output of knip:

 $ npx knip
Unused files (12)
api/lookupshare.ts                                                   
api/share.ts                                                         
public/wasm_exec.js                                                  
src/components/ui/tabs.tsx                                           
src/services/events.ts                                               
src/spicedb-common/components/ReadOnlyRelationshipsGrid.tsx          
src/spicedb-common/protodefs/authzed/api/v0/core_pb.ts               
src/spicedb-common/protodefs/authzed/api/v0/developer_pb.ts          
src/spicedb-common/protodefs/google/api/expr/v1alpha1/checked_pb.ts  
src/spicedb-common/protodefs/google/api/expr/v1alpha1/syntax_pb.ts   
src/spicedb-common/protodefs/impl/v1/impl_pb.ts                      
src/spicedb-common/protodefs/impl/v1/pgrevision_pb.ts                
Unused dependencies (15)
@apollo/client                    package.json:7:6 
@aws-sdk/client-s3                package.json:8:6 
@apollo/link-context              package.json:9:6 
@connectrpc/connect               package.json:11:6
@connectrpc/connect-web           package.json:12:6
@glideapps/glide-data-grid-cells  package.json:18:6
@radix-ui/react-tabs              package.json:26:6
@vercel/node                      package.json:30:6
color-hash                        package.json:34:6
google-protobuf                   package.json:40:6
graphql                           package.json:41:6
install                           package.json:42:6
markdown-it                       package.json:45:6
string.prototype.replaceall       package.json:57:6
tailwindcss                       package.json:60:6
Unused devDependencies (9)
@testing-library/react          package.json:70:6
@testing-library/user-event     package.json:71:6
@types/color-hash               package.json:72:6
@types/markdown-it              package.json:77:6
@types/react-copy-to-clipboard  package.json:81:6
@types/styled-components        package.json:84:6
@types/use-deep-compare-effect  package.json:85:6
postcss-safe-parser             package.json:94:6
tw-animate-css                  package.json:96:6
Unlisted dependencies (2)
react-scripts  src/spicedb-common/react-app-env.d.ts     
ajv            src/spicedb-common/validationfileformat.ts

Testing

 docker build . -t play && docker run -it -p 3000:3000 play

and then verify that everything looks good.

@vercel
Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 5:37pm

package.json Outdated
"@tanstack/react-router": "^1.119.0",
"@tanstack/react-router-devtools": "^1.119.1",
"@vercel/node": "^5.2.0",
"ajv": "^8.17.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

. generate-config-env.sh

validate_env "$env_file"
generate_env "$env_file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two functions aren't defined

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I spent a second trying to figure out where the connect references went and then realized that it's because we aren't calling the developer service anymore.

@miparnisari miparnisari merged commit b4f8e9b into main Jun 3, 2025
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants