Apply includePatterns and excludePatterns when walking for files#116
Open
zetafunction wants to merge 3 commits intoautobrr:mainfrom
Open
Apply includePatterns and excludePatterns when walking for files#116zetafunction wants to merge 3 commits intoautobrr:mainfrom
zetafunction wants to merge 3 commits intoautobrr:mainfrom
Conversation
This allows subdirectories to be excluded by name.
Collaborator
|
Hey! Thanks for the PR 👍
This sounds like the most sensible option to me I think 🤔 But either way, the important part is to keep it simple, and easy for users to understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows subdirectories to be excluded by name; mktorrent supports this. Useful to avoid including directories like
ANY!,FAB!, orMAKEMKVin torrents.I'm not sure if this is the best approach, since it does make it more annoying to use
mkbrrif you use--includewith torrents that include multiple subdirectories; after this, you'll need to include all intermediate subdirectories in the--includepatterns as well.I experimented with another approach to support matching on the path when a pattern contains path separators but it felt clunkier: in the
MAKEMKVexample, you might need to pass something like--exclude "MAKEMKV/*,MAKEMKV/*/*,MAKEMKV/*/*/*".Another approach is to add
--includeDirsand--excludeDirsand use those specifically for subdirectory checks to avoid changing the current meaning of--includeand--exclude.