Catch exceptions in exec callback to ensure Promise is rejected#49
Open
chenhuang444 wants to merge 1 commit intoautomation-stack:masterfrom
Open
Catch exceptions in exec callback to ensure Promise is rejected#49chenhuang444 wants to merge 1 commit intoautomation-stack:masterfrom
chenhuang444 wants to merge 1 commit intoautomation-stack:masterfrom
Conversation
Author
|
Resolves this issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds try-catch block to exec callback for machineId()
Why
A Promise has an implicit try-catch reject logic. However, the callback from
execis not handled by this implicit try-catch. Thus any exceptions thrown inexpose()will not be caught and the promise will not be rejected.I noticed this when some of my users had a
TypeError: Cannot read property 'replace' of undefinederror on sentry
Risk
Low: simple try catch block, does not change original resolve, reject behavior