added center-method focus to sdfstudio-data#196
Open
marcostrinca wants to merge 8 commits intoautonomousvision:masterfrom
Open
added center-method focus to sdfstudio-data#196marcostrinca wants to merge 8 commits intoautonomousvision:masterfrom
marcostrinca wants to merge 8 commits intoautonomousvision:masterfrom
Conversation
Author
|
After reading #90 I thought this PR was unnecessary. Took me a couple minutes to realize the first is related to nerfstudio dataparser instead of sdfstudio dataparser. |
Member
|
@marcostrinca Thanks for the PR but seems like this PR contains multiple changes (centering, adding mini-omidata, foreground masks). Would you mind split it to different PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick update do sdfstudio dataparser allowing users to choose "focus" to center poses.
An example:
ns-train neus sdfstudio-data ./mydata --center-method focusTested with neus and neus-facto with my own datasets after running
process_nerfstudio_to_sdfstudio.pyI've used the code from the updated version of nerfstudio repo.
Note: the change I did in nerfstudio_collate.py to remove torch._six.string_classes was to make it compatible with new versions of pytorch. I've been using pytorch 2.0.1 by the way.