refactor: implement browser preferences types and validation#294
Open
ArthurRodrigues4433 wants to merge 6 commits intoautoscrape-labs:mainfrom
Open
refactor: implement browser preferences types and validation#294ArthurRodrigues4433 wants to merge 6 commits intoautoscrape-labs:mainfrom
ArthurRodrigues4433 wants to merge 6 commits intoautoscrape-labs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Opa, tudo bem? precisa de alguma ajuda com os erros? |
Author
|
Sim, Está passando nos testes locais mas sempre falha nos teste aqui do GitHub! |
652071c to
b35cced
Compare
225164b to
c8731eb
Compare
d2c8b63 to
0ba0fa7
Compare
Member
|
Hello @ArthurRodrigues4433, obrigado pela contribuição e perdao pela demora. Consegue dar uma olhada nos conflitos? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Esta PR refatora o sistema de preferências do browser (
ChromiumOptions) para adicionar tipagem forte, validação e melhor tratamento de erros. As principais mudanças incluem:TypedDictsparaBrowserPreferences,DownloadPreferenceseProfilePreferences, garantindo tipo seguro e autocomplete em IDEs.PREFERENCE_SCHEMApara validação de caminhos e tipos de valores._validate_pref_pathe_validate_pref_valueadicionados para checagem rigorosa de caminhos e tipos de preferências.browser_preferences,prompt_for_download,password_manager_enabled,open_pdf_externally) para refletirem tipagem correta e retornaremOptionalquando apropriado.WrongPrefsDict,InvalidPreferencePatheInvalidPreferenceValue.temp_dir_managere no tratamento de argumentos doChromiumOptions.Related Issue(s)
#289
Type of Change
How Has This Been Tested?
Testing Checklist
Screenshots
Implementation Details
API Changes
Não há mudanças na API pública. As alterações são internas e mantêm compatibilidade total com o código existente.
Additional Info
Checklist before requesting a review
poetry run task lintand fixed any issuespoetry run task testand all tests pass