Skip to content

virtual_network/passt_function: ignore additional warning#6794

Open
smitterl wants to merge 1 commit intoautotest:masterfrom
smitterl:passt_function
Open

virtual_network/passt_function: ignore additional warning#6794
smitterl wants to merge 1 commit intoautotest:masterfrom
smitterl:passt_function

Conversation

@smitterl
Copy link
Contributor

@smitterl smitterl commented Feb 5, 2026

If power management is not available virtqemud log will contain a warning. This is not related to the test case and can be ignored.

Summary by CodeRabbit

  • Tests
    • Enhanced warning detection filtering in test suite to improve accuracy of test failure identification and reporting.

If power management is not available virtqemud log will contain a
warning. This is not related to the test case and can be ignored.

Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

The change modifies warning detection logic in a test file by replacing a simple exclude-and-grep approach with a more comprehensive ignore strategy. An ignore_patterns string is introduced to filter out specific warnings related to qemuDomainObjTaintMsg and virQEMUCapsInit, which are then excluded using grep -Ev before checking for remaining warnings. The command is executed with shell mode enabled and its result determines test pass/fail status.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: ignoring an additional warning in the passt_function test file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@smitterl smitterl requested a review from nanli1 February 5, 2026 15:28
@smitterl
Copy link
Contributor Author

smitterl commented Feb 5, 2026

JOB ID     : 14d21ce43d13d061be33028e151d80b72aa8508a
JOB LOG    : /var/log/avocado/job-results/job-2026-02-05T10.24-14d21ce/job.log
 (1/1) type_specific.io-github-autotest-libvirt.virtual_network.passt.interface_function.no_domain_name_opts.vhostuser.ip_portfw.ip_addr.root_user: STARTED
 (1/1) type_specific.io-github-autotest-libvirt.virtual_network.passt.interface_function.no_domain_name_opts.vhostuser.ip_portfw.ip_addr.root_user:  PASS (314.10 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/log/avocado/job-results/job-2026-02-05T10.24-14d21ce/results.html
JOB TIME   : 315.49 s

@nanli1
Copy link
Contributor

nanli1 commented Feb 6, 2026

@qiankehan hi hhan , Could you review this passt patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants