Build tax content file for location async#160
Open
joshwaldrep wants to merge 2 commits intoavadev:21.3.2from
Open
Build tax content file for location async#160joshwaldrep wants to merge 2 commits intoavadev:21.3.2from
joshwaldrep wants to merge 2 commits intoavadev:21.3.2from
Conversation
…ntFileForLocationAsync
… new LocationTaxContent class
Author
|
There's an open issue for this, but I don't have access to link it. Invalid response type BuildTaxContentFile(ForLocation)(Async) #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect deserialization of the BuildTaxContentFileForLocationAsync method. The response is an array of tax locations, item codes, and rates. The SDK is trying to deserialize it into a FileResult Object. The call always fails on the deserialization.
I couldn't find a class that matched the return values of the API so I added one. If there is an existing class, that would probably be better. I had to assume the data types based on the values returned by calling the API directly and looking through the other model classes.
I don't know Avalara's documentation standards so there will probably be some updates needed before this is merged.
I didn't find anything in the tests project that references this method.