Use 'RestCallFileAsync' instead of 'RestCallAsync' in DownloadBatchAsync#165
Open
ReazonIAm wants to merge 1 commit intoavadev:mainfrom
Open
Use 'RestCallFileAsync' instead of 'RestCallAsync' in DownloadBatchAsync#165ReazonIAm wants to merge 1 commit intoavadev:mainfrom
ReazonIAm wants to merge 1 commit intoavadev:mainfrom
Conversation
…ync, which causes parser to throw exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadBatchAsync always throws parser exception, and uses RestCallAsync.
DownloadBatch, on the other hand uses RestCallFile (Which still calls RestCallFileAsync), and works without any problem.
I suggest making these two functions to use the same logic, at least for the sake of consistency.
This quick fix makes them work the same, and seems to solve the problem(I used changed version as the reference to run tests - no exceptions thrown).