Make visible response status in the second 'then'#207
Open
lulusjhos wants to merge 1 commit intoavadev:mainfrom
Open
Make visible response status in the second 'then'#207lulusjhos wants to merge 1 commit intoavadev:mainfrom
lulusjhos wants to merge 1 commit intoavadev:mainfrom
Conversation
jefflulus
approved these changes
Dec 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Avalara documentation says:
...AvaTax API call produces an error, it responds using the standard HTTP error response codes
Handling Error Messages
But we can not get the response status since Avalara is returning response.json(), so the subsequent
thenandcatchonly get the result of response.json() which is the body of the response. Therefore the responsestatusis not visible in the secondthen