Add Liquid Glass effect for Karaoke view (macOS 26+)

[gitmichaelqiu]

If current system >= 26, use NSGlassEffectView.

Opacity = 0% (with comparison of NSVisualEffectView):

Opacity = 20%:

Opacity = 50%:

[aviwad]

Awesome. I'll give it a try.

[gitmichaelqiu]

Found an issue: in the light appearance, if the opacity <30%, because the lyrics are white, the readability will be awful. Sorry, when I was editing, I only tested the dark appearance.

Opacity=0%:

Opacity = 30%:

Although with an opacity of 30% and a white appearance, the "Liquid Glass" effect is barely visible.

So my solution is to use foregroundStyle(.primary) for lyrics and remove .preferredColorScheme(.dark) in FloatingPanel.swift to make it effective:

Opcity = 30%:

Opcity = 0%:

[aviwad]

Hmm... not a good fix... I generate the color to ensure legibility with white text. (the color I fetch from Spotify is also generated with the use case of having enough contrast against white text). Perhaps we can set a dark mode color scheme on whatever container is holding the NSGlassView? Not sure how to set that in AppKit

[aviwad]

Sorry if the previous comment sounded rude. I'm still trying to find a workaround, to force dark mode on the karaoke view's glass. I'm trying to wrap the NSHostingView inside an NSGlassEffectView so the glass is aware of the contents.

The problem now comes with communicating the NSHostingView's size changes to the GlassEffectView. I'll figure this out soon. Thank you for the PR!

[gitmichaelqiu]

No worries. I am not offended at all. 😄

And sorry for the late reply, I have edited the code locally and forgot to sync commits to GitHub 😅.

I was working on rewriting the code in SwiftUI because it automatically manages the font/background colors. The current work, in my opinion, looks wonderful!

CleanShot.2025-11-05.at.17.13.36.mp4

When the transparency > 35%, the code forces the foregroundStyle to be white. Otherwise, it is adjusted by SwiftUI.

I have committed the code; only KaraokeView.swift is modified. Currently, there is a drag when a small Karaoke window is expanded to a larger one, because of the default animation of the Liquid Glass (I am finding ways to disable it).

Except that, no obvious bugs are observed.

[gitmichaelqiu]

By the way, because I merged my old branch with your newest one, some other files have changed (to your newest code). I have only changed KaraokeView.swift.

[gitmichaelqiu]

Lemme know if the new method works for you!

[aviwad]

Ahh I'm so sorry I haven't been able to review this in time! I graduate in a couple days. I'll take a look soon-ish! Sorry for the wait.