Failsafe exit setting for awful.popup in doc example #3959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first
awful.widget.layoutlistpopup example does not show how to bind the popup to a widget or a button press.Nevertheless the popup is automatically shown upon creation so I would consider adding
visible = falseto avoid that and let a binding show it.Also it is not removed from display unless the user picks something, not even after an awesome restart, so I think adding this option which lets the unaware user click the right mouse button to make the popup disappear without being forced to select a layout should be set as a sane default/protection.
I would also consider adding ontop so it is not covered by clients/more visible when active since it is usually an immediate type of action.