check SO_ERROR after nonblocking connect#158
Open
psumbera wants to merge 1 commit intoawesomized:v1.xfrom
Open
check SO_ERROR after nonblocking connect#158psumbera wants to merge 1 commit intoawesomized:v1.xfrom
psumbera wants to merge 1 commit intoawesomized:v1.xfrom
Conversation
Author
|
This is how test failed on Solaris: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Solaris, several memcached_errors tests failed because the client treated a nonblocking connect as successful as soon as poll/select reported the socket writable, then immediately attempted a send without first checking SO_ERROR. When the connect had actually failed, send() returned EPIPE, which libmemcached reported as MEMCACHED_SYSTEM_ERROR instead of MEMCACHED_CONNECTION_FAILURE. This change fixes the connect race by checking SO_ERROR in IO_POLL_CONNECT before declaring success, and also normalizes mid-connection write failures by mapping EPIPE/ENOTCONN/ECONNRESET to MEMCACHED_CONNECTION_FAILURE (marking the instance dead).