feat: add --show-estimates flag to job list and job get#992
Open
vinadomi11 wants to merge 5 commits intoaws-deadline:mainlinefrom
Open
feat: add --show-estimates flag to job list and job get#992vinadomi11 wants to merge 5 commits intoaws-deadline:mainlinefrom
vinadomi11 wants to merge 5 commits intoaws-deadline:mainlinefrom
Conversation
jairaws
reviewed
Feb 5, 2026
| def cli_job(): | ||
| """ | ||
| def _format_duration(seconds: float) -> str: | ||
| """Format seconds as human-readable duration (e.g., '1 hour, 30 minutes').""" |
There was a problem hiding this comment.
There seems to an issue with the comment quotes (e.g. """). The one in line 108 should be removed.
There was a problem hiding this comment.
Issue addressed in the latest revision.
jairaws
reviewed
Feb 5, 2026
| return ", ".join(parts) | ||
|
|
||
|
|
||
| def _estimate_completion_time(job: dict) -> Optional[str]: |
There was a problem hiding this comment.
This is pretty cool, @vinadomi11! Could we add unit tests?
jairaws
reviewed
Feb 6, 2026
| def cli_job(): | ||
| """ | ||
| def _format_duration(seconds: float) -> str: | ||
| """Format seconds as human-readable duration (e.g., '1 hour, 30 minutes').""" |
There was a problem hiding this comment.
Issue addressed in the latest revision.
| ) | ||
| class TestEstimateCompletionTime: | ||
| def test_format_duration_seconds(self): | ||
| from deadline.client.cli._groups.job_group import _format_duration |
There was a problem hiding this comment.
Could we move all the imports to the top of the file? As opposed to have an import in each test.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Users have no way to see estimated completion time for in-progress jobs from the CLI. This makes it harder to plan and monitor long-running render jobs.
What was the solution? (How)
Added a --show-estimates flag to deadline job list and deadline job get commands that displays estimated time remaining for in-progress jobs. The estimate is calculated by:
Computing average time per completed task
Multiplying by remaining tasks (running + pending)
Output shows human-readable durations like "5 minutes" or "1 hour, 30 minutes".
What is the impact of this change?
New optional CLI flag - no impact on existing behavior.
How was this change tested?
Have you run the unit tests?
Have you run the integration tests?
Was this change documented?
Are relevant docstrings in the code base updated?
Has the README.md been updated?
Does this PR introduce new dependencies?
This PR does not add any new dependencies.
Is this a breaking change?
No - this adds an optional flag with no changes to existing behavior.
Does this change impact security?
No security impact.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.