fix: show resource ID in dropdown when user lacks list permission#993
Open
rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
Open
fix: show resource ID in dropdown when user lacks list permission#993rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
rickrams wants to merge 1 commit intoaws-deadline:mainlinefrom
Conversation
When a user has a farm/queue ID configured but lacks permission to list farms/queues, the settings dropdown would show '<none selected>'. Now it displays the configured ID instead, allowing users with limited permissions to still see their configured resources. Signed-off-by: rickrams <rickrams@users.noreply.github.com>
github-actions
bot
added
the
waiting-on-maintainers
|
leongdl
reviewed
Feb 7, 2026
| index = self.box.findData(selected_id) | ||
| if index >= 0: | ||
| self.box.setCurrentIndex(index) | ||
| elif selected_id: |
Contributor
There was a problem hiding this comment.
Can we add a unit test please, this case is interesting and we need the test to keep re-inforcing why it is needed.
And add a comment when this happens, EG: user has queue permission but no farm permissions. It'll be forgotten soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user has a farm/queue ID configured but lacks permission to list farms/queues, the settings dropdown would show ''. Now it displays the configured ID instead, allowing users with limited permissions to still see their configured resources.
Fixes:
What was the problem/requirement? (What/Why)
Trying to improve the experience of queue only users.
What was the solution? (How)
Showing the farm ID instead of 'none selected' when the user has no permissions to farms.
What is the impact of this change?
Improved UX
How was this change tested?
Tests were run and local tests with the houdini submitter
See DEVELOPMENT.md for information on running tests.
downloadorasset_syncmodules? NoWas this change documented?
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change? No
Does this change impact security? No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.