Skip to content

test: extract DF idempotency e2e tests#4994

Open
dreamorosi wants to merge 3 commits intomainfrom
test/decouple_df_idempotency
Open

test: extract DF idempotency e2e tests#4994
dreamorosi wants to merge 3 commits intomainfrom
test/decouple_df_idempotency

Conversation

@dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Feb 5, 2026

Summary

Changes

Please provide a summary of what's being changed

As described in the linked issue, this PR extracts the Durable functions e2e tests from the other e2e tests of the Idempotency utility to make it easier to conditionally run them based on runtime version.

I have verified that the tests are running correctly with 3 successful consecutive runs:

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4993


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from svozza February 5, 2026 17:11
@dreamorosi dreamorosi self-assigned this Feb 5, 2026
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 5, 2026
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Feb 5, 2026
@dreamorosi dreamorosi changed the title Test/decouple df idempotency test: extract DF idempotency e2e tests Feb 5, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dreamorosi dreamorosi marked this pull request as ready for review February 5, 2026 17:14
import { IdempotencyTestNodejsFunctionAndDynamoTable } from '../helpers/resources.js';
import { RESOURCE_NAME_PREFIX } from './constants.js';

describe.skipIf(getRuntimeKey() === 'nodejs20x')(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, hadn't heard of skipIf before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L PRs between 100-499 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: extract Durable Functions Idempotency tests

2 participants