Skip to content

fix: treat null matdesc as empty#448

Merged
kessplas merged 2 commits intomainfrom
null-matdesc
Jan 24, 2025
Merged

fix: treat null matdesc as empty#448
kessplas merged 2 commits intomainfrom
null-matdesc

Conversation

@kessplas
Copy link
Contributor

Issue #, if available: n/a

Description of changes: Apparently, in v2, the client would default to the empty map {} when the material description is not present. This is an edge case, but in the interest of being as compatible as possible, v3 will do the same.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas requested a review from a team as a code owner January 24, 2025 18:31
ajewellamz
ajewellamz previously approved these changes Jan 24, 2025
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kessplas kessplas merged commit bcd711e into main Jan 24, 2025
14 checks passed
josecorella pushed a commit that referenced this pull request Jan 24, 2025
## [3.3.1](v3.3.0...v3.3.1) (2025-01-24)

### Fixes

* KMS Dependency is required ([44e9886](44e9886))
* treat null matdesc as empty ([#448](#448)) ([bcd711e](bcd711e))
* unbounded streams are not supported ([#422](#422)) ([034bb89](034bb89))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants