fix/image-pull-policy

[OlTrenin]

What type of PR is this?
bug

Which issue does this PR fix?:
Fixes #3566

What does this PR do / Why do we need it?:
This PR adds the missing imagePullPolicy configuration for the aws-node container in the Helm chart template.

Currently, the image.pullPolicy value exists in the values.yaml file but is not referenced in the daemonset template for the main aws-node container. This creates an inconsistency where:

• aws-vpc-cni-init init container supports configurable imagePullPolicy
• aws-eks-nodeagent container supports configurable imagePullPolicy
• aws-node container does NOT support configurable imagePullPolicy

Without this fix, users cannot configure the imagePullPolicy for the aws-node container through the values file and must resort to post-renderer mutations as a workaround.

Changes made:

1. Added imagePullPolicy: {{ .Values.image.pullPolicy }} to the aws-node container spec in charts/aws-vpc-cni/templates/daemonset.yaml
2. Updated documentation in charts/aws-vpc-cni/README.md to reflect the actual default values (Always instead of incorrectly documented IfNotPresent)

Testing done on this change:

• Verified the template syntax is correct and follows the same pattern as init and nodeAgent containers
• Confirmed all three containers (aws-node, aws-vpc-cni-init, aws-eks-nodeagent) now consistently reference their respective pullPolicy values
• Validated that the change only adds a missing field and does not modify existing behavior when default values are used

# Verified imagePullPolicy is now present for all three containers
$ grep -n "imagePullPolicy:" charts/aws-vpc-cni/templates/daemonset.yaml
44:        imagePullPolicy: {{ .Values.init.image.pullPolicy }}
73:          imagePullPolicy: {{ .Values.image.pullPolicy }}
136:          imagePullPolicy: {{ .Values.nodeAgent.image.pullPolicy }}

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No breaking changes. This is a backward-compatible change that:
- Uses existing values from values.yaml (default: Always)
- Only adds a missing field that should have been there from the beginning
- Does not change the default behavior when upgrading (the field will be populated with the same default value that was being used implicitly)

Does this change require updates to the CNI daemonset config files to work?:
No. This change only affects the Helm chart template. Users can update their deployments with a standard helm upgrade command. The change works seamlessly with kubectl patch of the image tag.

Does this PR introduce any user-facing change?:
Yes. Users can now configure the imagePullPolicy for the aws-node container through the Helm values file.

Add support for configurable imagePullPolicy on aws-node container via image.pullPolicy value in Helm chart, bringing feature parity with aws-vpc-cni-init and aws-eks-nodeagent containers.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[yash97]

Thanks for the contribution, but can you make the pullPolicy value actually, IfNotPresent, better option than Always hogging bandwidth.

[OlTrenin]

Thanks for the contribution, but can you make the pullPolicy value actually, IfNotPresent, better option than Always hogging bandwidth.

sure, I've improved

[OlTrenin]

@yash97 hi, could you help me with pipline?

[OlTrenin]

@yash97 hi! Is this PR ready for deploy?