fix: Skip SetupENINetwork for trunk ENIs in IPv6 mode#3573
Open
jfernandez wants to merge 1 commit intoaws:masterfrom
Open
fix: Skip SetupENINetwork for trunk ENIs in IPv6 mode#3573jfernandez wants to merge 1 commit intoaws:masterfrom
jfernandez wants to merge 1 commit intoaws:masterfrom
Conversation
Trunk ENIs in IPv6 prefix delegation mode have no IP addresses and only
serve as attachment points for branch ENIs. Attempting to call
SetupENINetwork with an empty primaryIP causes "numerical result out of
range" errors when net.ParseIP("") returns nil.
Add !isTrunkENI check before SetupENINetwork call to skip network setup
for trunk ENIs, consistent with existing checks that skip IP allocation
and IP rules for trunk ENIs.
Closes: aws#3572
Signed-off-by: Jose Fernandez <josef@netflix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix?:
Closes: #3572
What does this PR do / Why do we need it?:
Trunk ENIs in IPv6 prefix delegation mode have no IP addresses and only serve as attachment points for branch ENIs. Attempting to call SetupENINetwork with an empty primaryIP causes "numerical result out of range" errors when net.ParseIP("") returns nil.
Add !isTrunkENI check before SetupENINetwork call to skip network setup for trunk ENIs, consistent with existing checks that skip IP allocation and IP rules for trunk ENIs.
Testing done on this change:
Tested on the same environment I reported in the issue, and the error went away.
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.