chore: add migration examples #2057
Open
rishav-karanjit wants to merge 36 commits intoddbec-with-sdk-v2from
Open
chore: add migration examples #2057rishav-karanjit wants to merge 36 commits intoddbec-with-sdk-v2from
rishav-karanjit wants to merge 36 commits intoddbec-with-sdk-v2from
Conversation
This reverts commit ec8077c.
This reverts commit ec8077c.
…database-encryption-sdk-dynamodb into rishav/ddbec-v2/adapter
Added permissions for contents and id-token in PR CI workflow.
This reverts commit 9c94715.
5a7811f to
1b87db7
Compare
josecorella
requested changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
do we usually check this in?
Comment on lines
+26
to
+27
| import software.amazon.cryptools.dynamodbencryptionclientsdk2.encryption.DynamoDBEncryptor; | ||
| import software.amazon.cryptools.dynamodbencryptionclientsdk2.encryption.providers.DirectKmsMaterialsProvider; |
Contributor
There was a problem hiding this comment.
can we rename these new packages?
from
package software.amazon.cryptools.dynamodbencryptionclientsdk2.*;
to
package com.amazonaws.services.dynamodbv2.datamodeling.sdkv2.*;
Base automatically changed from
rishav/ddbec-v2/adapter
to
ddbec-with-sdk-v2
February 24, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Migration example from DDBEC with SDK V2 to DB-ESDK
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.