Skip to content

refactor(amazonq): fix sagemaker credential log typo#8104

Merged
laileni-aws merged 1 commit intoaws:masterfrom
parameja1:fix-smus-log
Sep 29, 2025
Merged

refactor(amazonq): fix sagemaker credential log typo#8104
laileni-aws merged 1 commit intoaws:masterfrom
parameja1:fix-smus-log

Conversation

@parameja1
Copy link
Contributor

Problem

Typo in log statement for Sagemaker Update IAM Credential logic currently prints expiration time

Solution

  • Fix typo to show availability of field in credentials
  • npm run compile && npm run test succeeded

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@parameja1 parameja1 requested a review from a team as a code owner September 28, 2025 23:54
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@parameja1 parameja1 changed the title chore(amazonq): fix sagemaker credential log typo refactor(amazonq): fix sagemaker credential log typo Sep 28, 2025
@parameja1 parameja1 closed this Sep 28, 2025
@parameja1 parameja1 reopened this Sep 28, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@laileni-aws laileni-aws merged commit 10fb7f6 into aws:master Sep 29, 2025
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants