feat(smus): Add support for IAM-based domains for Unified Studio#8345
Merged
manodnyab merged 18 commits intoaws:masterfrom Nov 21, 2025
Merged
feat(smus): Add support for IAM-based domains for Unified Studio#8345manodnyab merged 18 commits intoaws:masterfrom
manodnyab merged 18 commits intoaws:masterfrom
Conversation
## Problem Merging some staged feature enhancements for SMUS support in AWS Toolkit. ## Solution - Added IAM support for SMUS. - Contains bug fixes and text re-wording based on user feedback. Eg - Clarifies auth mode to Identity Center instead of SSO as Toolkit SMUS does not support SAML yet. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: aws-ides-bot <github-aws-toolkit-automation@amazon.com> Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: Bhargava Varadharajan <vabharga@amazon.com> Co-authored-by: kzr <kzr@amazon.com> Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com> Co-authored-by: Sherry Lu <xiaoluk@amazon.com> Co-authored-by: Sherry Lu <75588211+XiaoxuanLu@users.noreply.github.com> Co-authored-by: zulil <31738836+liuzulin@users.noreply.github.com> Co-authored-by: Zulin Liu <zulil@amazon.com> Co-authored-by: David <60020664+dhasani23@users.noreply.github.com> Co-authored-by: David Hasani <davhasan@amazon.com> Co-authored-by: Arkaprava De <arkaprava08@gmail.com> Co-authored-by: Arkaprava De <arkaprav@amazon.com> Co-authored-by: Keyu Wu <Keyu.Wu.Wky@gmail.com> Co-authored-by: chungjac <chungjac@amazon.com> Co-authored-by: aws-asolidu <asolidu@amazon.com> Co-authored-by: Newton Der <dernewtz@amazon.com> Co-authored-by: Newton Der <newton.der@gmail.com> Co-authored-by: Will Lo <96078566+Will-ShaoHua@users.noreply.github.com> Co-authored-by: Boyu <wangby56@gmail.com> Co-authored-by: atontb <104926752+atonaamz@users.noreply.github.com> Co-authored-by: Richard Li <742829+rli@users.noreply.github.com> Co-authored-by: Shruti Sinha <44882001+shruti0085@users.noreply.github.com> Co-authored-by: Bhavya Sharma <bhavya2109sharma@gmail.com> Co-authored-by: Roger Zhang <ruojiazh@amazon.com> Co-authored-by: Tai Lai <ctlai95@gmail.com> Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com> Co-authored-by: Dylan Ross <90357952+dylanraws@users.noreply.github.com> Co-authored-by: BlakeLazarine <blake.l.lazarine@gmail.com> Co-authored-by: Blake Lazarine <blakelaz@amazon.com> Co-authored-by: tobixlea <tobixlea@amazon.com> Co-authored-by: seshubaws <116689586+seshubaws@users.noreply.github.com> Co-authored-by: Bhavya Sharma <bhavyssh@amazon.com>
Merge master into feature/smus
…ws#8324) ## Problem When users sign in to SageMaker Unified Studio with IAM credentials, if they use the step-by-step wizard to add a new profile, when the user is prompted to select a region, typing in a region code such as `us-east-1` to filter the results does not show expected results because the QuickPick matches only on the item labels, not on their description. <img width="602" height="195" alt="image" src="https://github.com/user-attachments/assets/695f064f-b6bd-4de6-bf9a-71741b3b566d" /> ## Solution Update the region selection QuickPick to also match options according to the description (in addition to the label). <img width="598" height="326" alt="image" src="https://github.com/user-attachments/assets/902ad2ed-19f3-4be0-bd6e-3b768745f9ba" /> --- Tests are not necessary for this change, given that we are just changing a config option of the quick pick menu. Not adding a changelog because this updates unreleased functionality in the `feature/smus` branch. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
Merge master into feature/smus
Moving staged changes for SMUS IAM mode support for release
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
laileni-aws
reviewed
Nov 21, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Feature", | |||
Contributor
There was a problem hiding this comment.
I guess this is not for SMUS
Contributor
|
Code diff: |
laileni-aws
approved these changes
Nov 21, 2025
manodnyab
approved these changes
Nov 21, 2025
Contributor
|
Discussed offline failing linter to be addressed in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges changes to add support in SMUS to use IAM-based domains. Previously we only supported IdC-based domains and with this, customers have the flexibility to use both the authentication options.
feature/xbranches will not be squash-merged at release time.