Skip to content

fix(cloudformation): load stacks lazily to avoid error notification o…#8349

Merged
manodnyab merged 2 commits intoaws:masterfrom
Zee2413:fix/cfn/lazy-load-stacks
Nov 21, 2025
Merged

fix(cloudformation): load stacks lazily to avoid error notification o…#8349
manodnyab merged 2 commits intoaws:masterfrom
Zee2413:fix/cfn/lazy-load-stacks

Conversation

@Zee2413
Copy link
Contributor

@Zee2413 Zee2413 commented Nov 21, 2025

…n startup

Problem

New CloudFormation feature eagerly loaded stacks resulting in error notification if credentials were not set properly. Eager loading is not desirable even if credentials would work because user may not open the panel or intend to use the data.

Solution

Lazy load stacks.
Tested:

  • stacks do not load on startup
  • switching regions does not eagerly load stacks
  • pagination with load more works as before
  • deploying template if stacks were never loaded triggers loading as stacks are refreshed (desired behavior)
  • if StacksNode is expanded and region is switched then stacks are loaded (desired behavior)

Dead code removal: polling was disabled earlier and unused.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Zee2413 Zee2413 requested a review from a team as a code owner November 21, 2025 05:17
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@Zee2413 Zee2413 force-pushed the fix/cfn/lazy-load-stacks branch from db2fb62 to 8cee5b9 Compare November 21, 2025 05:20
@Zee2413 Zee2413 force-pushed the fix/cfn/lazy-load-stacks branch from 8cee5b9 to f011515 Compare November 21, 2025 05:24
@manodnyab manodnyab merged commit 220d65c into aws:master Nov 21, 2025
45 of 46 checks passed
aws-ajangg pushed a commit to aws-ajangg/aws-toolkit-vscode that referenced this pull request Jan 15, 2026
aws#8349)

…n startup

## Problem
New CloudFormation feature eagerly loaded stacks resulting in error
notification if credentials were not set properly. Eager loading is not
desirable even if credentials would work because user may not open the
panel or intend to use the data.

## Solution
Lazy load stacks.
Tested:
- stacks do not load on startup
- switching regions does not eagerly load stacks
- pagination with load more works as before
- deploying template if stacks were never loaded triggers loading as
stacks are refreshed (desired behavior)
- if StacksNode is expanded and region is switched then stacks are
loaded (desired behavior)

Dead code removal: polling was disabled earlier and unused.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants