fix(cloudformation): load stacks lazily to avoid error notification o…#8349
Merged
manodnyab merged 2 commits intoaws:masterfrom Nov 21, 2025
Merged
fix(cloudformation): load stacks lazily to avoid error notification o…#8349manodnyab merged 2 commits intoaws:masterfrom
manodnyab merged 2 commits intoaws:masterfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
db2fb62 to
8cee5b9
Compare
8cee5b9 to
f011515
Compare
kddejong
approved these changes
Nov 21, 2025
laileni-aws
approved these changes
Nov 21, 2025
laileni-aws
approved these changes
Nov 21, 2025
manodnyab
approved these changes
Nov 21, 2025
aws-ajangg
pushed a commit
to aws-ajangg/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2026
aws#8349) …n startup ## Problem New CloudFormation feature eagerly loaded stacks resulting in error notification if credentials were not set properly. Eager loading is not desirable even if credentials would work because user may not open the panel or intend to use the data. ## Solution Lazy load stacks. Tested: - stacks do not load on startup - switching regions does not eagerly load stacks - pagination with load more works as before - deploying template if stacks were never loaded triggers loading as stacks are refreshed (desired behavior) - if StacksNode is expanded and region is switched then stacks are loaded (desired behavior) Dead code removal: polling was disabled earlier and unused. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n startup
Problem
New CloudFormation feature eagerly loaded stacks resulting in error notification if credentials were not set properly. Eager loading is not desirable even if credentials would work because user may not open the panel or intend to use the data.
Solution
Lazy load stacks.
Tested:
Dead code removal: polling was disabled earlier and unused.
feature/xbranches will not be squash-merged at release time.