fix(smus): Do not call getDatabases when a catalog is an empty parent catalog#8363
Merged
chungjac merged 5 commits intoaws:masterfrom Dec 5, 2025
Merged
fix(smus): Do not call getDatabases when a catalog is an empty parent catalog#8363chungjac merged 5 commits intoaws:masterfrom
chungjac merged 5 commits intoaws:masterfrom
Conversation
PotatoWKY
reviewed
Nov 24, 2025
Contributor
There was a problem hiding this comment.
For my own understanding. Is this where we should add the change log for next release? Should we starting doing this for all our PRs?
Contributor
There was a problem hiding this comment.
The guidelines and process are documented here:
https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#changelog
Contributor
There was a problem hiding this comment.
Team can changeLog if they want to inform user about the fix, feature in the new release. Just like a small announcement/information for their context. Highly recommend changeLog for user facing changes.
PotatoWKY
reviewed
Nov 24, 2025
| } | ||
| return ( | ||
| catalog.FederatedCatalog?.ConnectionName === 'aws:redshift' || | ||
| catalog.CatalogProperties?.DataLakeAccessProperties?.CatalogType === 'aws:redshift' |
Contributor
There was a problem hiding this comment.
Nit: would it be simpler to just add ? on catalog?
return catalog?.FederatedCatalog?.ConnectionName === 'aws:redshift' ||
catalog?.CatalogProperties?.DataLakeAccessProperties?.CatalogType === 'aws:redshift'
PotatoWKY
approved these changes
Nov 24, 2025
laileni-aws
approved these changes
Dec 5, 2025
manodnyab
approved these changes
Dec 5, 2025
aws-ajangg
pushed a commit
to aws-ajangg/aws-toolkit-vscode
that referenced
this pull request
Jan 15, 2026
… catalog (aws#8363) ## Problem A bug is reported that when s3 table catalog is empty, there is getDatabases call being made and cause unwanted error ## Solution Handle the issue by not calling getDatabases when a catalog node is an empty parent node --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Zulin Liu <zulil@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A bug is reported that when s3 table catalog is empty, there is getDatabases call being made and cause unwanted error
Solution
Handle the issue by not calling getDatabases when a catalog node is an empty parent node
feature/xbranches will not be squash-merged at release time.