feat(sagemaker): Reconnection toolkit by msgupta-amazon · Pull Request #8485 · aws/aws-toolkit-vscode

msgupta-amazon · 2026-01-06T21:33:11Z

##Problem
Right now, we don't support reconnection from toolkit for hyperpod spaces.

##Solution
This PR will add the reconnection functionality which leads to seamless user experience.

The duplicate check is failing but we need that code at 2 places, one for initial connection and in detached-server so that when the user closes the main window, detached server is able to provide the seamless user experience.

##Notes
Tested the unit test cases and reconnection use cases end to end locally.

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2026-01-06T21:33:24Z

This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

msgupta-amazon · 2026-01-06T21:35:16Z

lint update

packages/core/resources/hyperpod_connect

packages/core/src/awsService/sagemaker/detached-server/routes/getHyperpodSession.ts

packages/core/src/awsService/sagemaker/detached-server/kubectlClientStub.ts

packages/core/src/awsService/sagemaker/hyperpodCommands.ts

aws-ajangg · 2026-01-14T00:05:08Z

has this been tested locally? if so, can you update the description

packages/core/src/awsService/sagemaker/detached-server/routes/getHyperpodSession.ts

packages/core/src/awsService/sagemaker/detached-server/kubectlClientStub.ts

NewtonDer · 2026-01-21T00:14:17Z

packages/core/src/awsService/sagemaker/commands.ts

-            appType
+            appType,
+            workspaceName,
+            undefined,


Please reconsider refactoring prepareDevEnvConnection to accept an options object instead of many ordered arguments. Especially since it seems like some of them can be optional/undefined. When the list of arguments eventually grows, it can be hard for others to use it because they have to maintain the same order of arguments, a lot of which may not be relevant to them.

packages/core/src/awsService/sagemaker/hyperpodCommands.ts

packages/core/src/awsService/sagemaker/hyperpodConnectionMonitor.ts

packages/core/src/awsService/sagemaker/hyperpodReconnection.ts

packages/core/src/awsService/sagemaker/hyperpodUtils.ts

…ode for windows

amazon-inspector-ohio · 2026-02-09T19:54:58Z

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

amazon-inspector-ohio · 2026-02-09T19:55:29Z

✅ I finished the code review, and didn't find any security or code quality issues.

- Parse API response JSON once instead of 3 times for better efficiency - Add error handling for JSON parsing failures - Extract complex connection key fallback logic to separate function - Add URL encoding for query parameters to handle special characters - Replace ChildProcess with native execFile in detached server to avoid vscode dependency - Add SAGEMAKER_LOCAL_SERVER_FILE_PATH environment variable to hyperpod connection - Store wsUrl and token in hyperpod mapping for reconnection support

laileni-aws · 2026-02-11T23:38:14Z

packages/core/src/awsService/sagemaker/detached-server/hyperpodMappingUtils.ts

+        return JSON.parse(content)
+    } catch (err: any) {
+        if (err.code === 'ENOENT') {
+            return {}


why do we return empty here?

laileni-aws · 2026-02-11T23:39:12Z

packages/core/src/awsService/sagemaker/detached-server/kubectlClientStub.ts

+export class KubectlClient {
+    private kubeConfig: k8s.KubeConfig
+    private k8sApi: k8s.CustomObjectsApi
+    private eksCluster: any


Assign datatype instead of any?

laileni-aws

Need internal team approval
Need to add a changeLog

laileni-aws · 2026-02-11T23:42:16Z

/retryBuilds

NewtonDer · 2026-02-12T18:47:17Z

Approved

packages/core/resources/hyperpod_connect.ps1

aws-asolidu · 2026-02-12T19:10:29Z

packages/core/src/awsService/sagemaker/detached-server/routes/getHyperpodSession.ts

+            try {
+                // Attempt to fetch EKS cluster details using AWS CLI
+                const region = connectionInfo.region || parse(connectionInfo.clusterArn).region
+                const { stdout } = await execFileAsync('aws', [


Why are we using the CLI instead of a typescript SDK? This will fail if the user does not have cli installed.

Ah, is this the "Deeplink" use case? If so can you clarify the UX we decided on.

aws-asolidu · 2026-02-12T19:19:18Z

packages/toolkit/.changes/next-release/Feature-8dac03d9-ef57-4018-a360-1f8a818b47ad.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "We can connect to hyperpod spaces through toolkit but now user will be able to save their work in case of connection disruption as we now support reconnection."


Is the right wording here?
Kinda sounds like we are releasing connect to hyperpod spaces and that the user can manually save their work.

Using kiro:
"This update enhances HyperPod Space connectivity in the Toolkit by adding reconnection support. In the event of a connection disruption, users can now seamlessly reconnect to their existing session and resume work without losing in-progress changes."

laileni-aws · 2026-02-12T20:27:51Z

/retryBuilds

ashishrp-aws · 2026-02-20T00:02:50Z

/retryBuilds

Adding connect script to support connection and reconnection in windows

laileni-aws · 2026-02-20T22:34:16Z

/retryBuilds

laileni-aws · 2026-02-23T18:49:28Z

/retryBuilds

msgupta-amazon requested a review from a team as a code owner January 6, 2026 21:33

msgupta-amazon changed the title ~~feat(Sagemaker): Reconnection toolkit~~ feat(sagemaker): Reconnection toolkit Jan 6, 2026

msgupta-amazon closed this Jan 6, 2026

msgupta-amazon reopened this Jan 6, 2026

msgupta-amazon marked this pull request as draft January 9, 2026 18:03

msgupta-amazon marked this pull request as ready for review January 9, 2026 22:51

aws-ajangg reviewed Jan 13, 2026

View reviewed changes

msgupta-amazon force-pushed the reconnection-toolkit branch from cb4fa4d to d0a38c3 Compare January 15, 2026 23:47

NewtonDer reviewed Jan 21, 2026

View reviewed changes

packages/core/src/awsService/sagemaker/hyperpodConnectionMonitor.ts Outdated Show resolved Hide resolved

packages/core/src/awsService/sagemaker/hyperpodReconnection.ts Outdated Show resolved Hide resolved

packages/core/src/awsService/sagemaker/hyperpodUtils.ts Outdated Show resolved Hide resolved

mgupta-om added 10 commits January 26, 2026 14:02

Added changes to support reconnection for hyperpod spaces

af0a244

Added unit test cases and made couple enhancements

16091f4

Enhanced the code and covered some edge cases

89a125d

Removed the duplicate code and enhanced the script

ebaf868

Lint errors fixed

ad0e06a

Lint errors fixed

11203e0

Comments addressed

ac33aeb

Hostname changes addressed

ee9de30

Enhancements after the merge

637ad40

Initial connection for windows environment and modified the current c…

9d59bb6

…ode for windows

laileni-aws closed this Feb 9, 2026

laileni-aws reopened this Feb 9, 2026

laileni-aws closed this Feb 9, 2026

laileni-aws reopened this Feb 9, 2026

Merge remote-tracking branch 'origin/master' into reconnection-toolkit

aa57428

mgupta-om and others added 2 commits February 11, 2026 15:27

Merge branch 'master' into reconnection-toolkit

899e1bc

laileni-aws reviewed Feb 11, 2026

View reviewed changes

laileni-aws approved these changes Feb 11, 2026

View reviewed changes

Changelog added

54335ee

joshuatowner approved these changes Feb 12, 2026

View reviewed changes

aws-asolidu reviewed Feb 12, 2026

View reviewed changes

packages/core/resources/hyperpod_connect.ps1 Show resolved Hide resolved

aws-asolidu reviewed Feb 12, 2026

View reviewed changes

Removing the powershell file

d6fc18d

aws-asolidu reviewed Feb 12, 2026

View reviewed changes

aws-asolidu approved these changes Feb 12, 2026

View reviewed changes

mgupta-om and others added 3 commits February 12, 2026 13:10

Changelog modified

7760048

Adding connect script to support connection and reconnection in windows

fb00e42

Merge branch 'master' into reconnection-toolkit

a0b6134

ashishrp-aws approved these changes Feb 20, 2026

View reviewed changes

ashishrp-aws closed this Feb 20, 2026

ashishrp-aws reopened this Feb 20, 2026

msgupta-amazon added 2 commits February 20, 2026 13:40

Merge pull request #1 from msgupta-amazon/reconnection-w

2db3648

Adding connect script to support connection and reconnection in windows

Merge branch 'master' into reconnection-toolkit

49a51d4

ashishrp-aws and others added 3 commits February 20, 2026 14:53

Merge branch 'master' into reconnection-toolkit

53c364c

fixed the lint errors

c730da1

Merge branch 'master' into reconnection-toolkit

3c842dc

laileni-aws merged commit 747f18c into aws:master Feb 23, 2026
25 of 34 checks passed

Conversation

msgupta-amazon commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 6, 2026

Uh oh!

msgupta-amazon commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aws-ajangg commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NewtonDer Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amazon-inspector-ohio bot commented Feb 9, 2026

Uh oh!

amazon-inspector-ohio bot commented Feb 9, 2026

Uh oh!

laileni-aws Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

laileni-aws Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

laileni-aws left a comment

Choose a reason for hiding this comment

Uh oh!

laileni-aws commented Feb 11, 2026

Uh oh!

NewtonDer commented Feb 12, 2026

Uh oh!

Uh oh!

aws-asolidu Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

aws-asolidu Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

aws-asolidu Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

msgupta-amazon Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

laileni-aws commented Feb 12, 2026

Uh oh!

ashishrp-aws commented Feb 20, 2026

Uh oh!

laileni-aws commented Feb 20, 2026

Uh oh!

laileni-aws commented Feb 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

msgupta-amazon commented Jan 6, 2026 •

edited

Loading