fix(sagemaker): enhance idle activity monitoring for appropriate shutdown#8584
Open
aws-ajangg wants to merge 9 commits intoaws:masterfrom
Open
fix(sagemaker): enhance idle activity monitoring for appropriate shutdown#8584aws-ajangg wants to merge 9 commits intoaws:masterfrom
aws-ajangg wants to merge 9 commits intoaws:masterfrom
Conversation
…ensure last active timestamp is being updated for remote ide
…rnel, and unsaved work checks
|
…ts and jupyter notebook, and modify logs to debug only
sgganjo
reviewed
Mar 2, 2026
| return false | ||
| } | ||
|
|
||
| const api = await jupyterExt.activate() |
There was a problem hiding this comment.
nit: can we rename api variable to something like jupyterExtApi or something to improve readability
| try { | ||
| const jupyterExt = vscode.extensions.getExtension('ms-toolsai.jupyter') | ||
| if (!jupyterExt) { | ||
| // Jupyter extension not installed, fall back to executionSummary check |
Contributor
Author
There was a problem hiding this comment.
comment wasn't updated from an earlier impl of the fix. it's been addressed to update the current impl
There was a problem hiding this comment.
Do we need to throw some kind of err/debug/logging info when we are not able to install the extension. Customer might not be sure what they need to do to allow extension installation specially if there is no internet access allowed in customer env.
Contributor
|
nit: To add a comment line instead of returning false when we don't find jupyterExt installed. else Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Test
feature/xbranches will not be squash-merged at release time.