feat(sam): sam codelen to support java gradle kts project#8609
Open
roger-zhangg wants to merge 1 commit intoaws:masterfrom
Open
feat(sam): sam codelen to support java gradle kts project#8609roger-zhangg wants to merge 1 commit intoaws:masterfrom
roger-zhangg wants to merge 1 commit intoaws:masterfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SAM Lambda CodeLens "Add Debug Configuration" does not appear for Java projects that use custom-named Gradle build scripts (e.g.,
brazil.gradle.kts). The extension hardcodedbuild.gradleas the only recognized Gradle build filename in both the file watcher glob pattern and the project root detection regex.Solution
Broadened the Gradle file detection patterns to match any
*.gradleor*.gradle.ktsfile instead of onlybuild.gradle:gradleBasePattern):'**/build.gradle'→'**/*.gradle{,.kts}'getLambdaHandlerCandidates):/^.*build.gradle$/→/^.*.gradle(.kts)?$/This allows the CodeLens to work with custom-named Gradle build scripts like
*.gradle.kts,build.gradle.kts, and the standardbuild.gradle.feature/xbranches will not be squash-merged at release time.